lkml.org 
[lkml]   [2004]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ACPI] [2.6 patch] drivers/acpi: remove unused exported functions
On Sat, Nov 06, 2004 at 08:39:34PM +0000, Matthew Wilcox wrote:
> On Fri, Nov 05, 2004 at 10:50:21PM +0100, Adrian Bunk wrote:
> > -acpi_status
> > -acpi_install_gpe_block (
> > - acpi_handle gpe_device,
> > - struct acpi_generic_address *gpe_block_address,
> > - u32 register_count,
> > - u32 interrupt_level);
> > -
> > -acpi_status
> > -acpi_remove_gpe_block (
> > - acpi_handle gpe_device);
> > -
>
> I just wrote a driver that uses these two. Probably best if you refer to
> http://developer.intel.com/technology/iapc/acpi/downloads/ACPICA-ProgRef.pdf
> before deleting "unused" functions as these are part of the published
> interfaces that the ACPICA provides.

If an in-kernel usage for some of the functions is coming soon simply
ignore these parts of my patch.

But if there's EXPORT_SYMBOL'ed code since nearly since nearly three
years in the kernel that has like drivers/acpi/hardware/hwtimer.c
exactly zero users, the only effect of this code is a code bloat for all
users of ACPI.

Prehaps #ifdef 0's are the best solution for published but unused
interfaces?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.069 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site