Messages in this thread | | | Date | Fri, 5 Nov 2004 19:22:59 -0800 | From | Chris Wedgwood <> | Subject | [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments |
| |
On Fri, Nov 05, 2004 at 02:16:05PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Thu, 04 Nov 2004 21:43:12 -0500, Jeff Garzik <jgarzik@pobox.com> wrote:
> > Chris, a useful follow-up patch (if Bart agrees) is a global > > search-n-replace of WIN_xxx constants with ATA_CMD_xxx constants. > > Depending on the size of the patch, it might even need to be split > > up across several patches.
Following are three patches doing just thus. They are against bk TOT with Bart's IDE tree pulled in.
> One ceveat here: hdreg.h and WIN_xxx are (ab)used by user-space so > for sure there will be complaints (not that we should care :)...
They should fork the values they need then, they are not kernel specific but come from some nightmarish specification :)
About the following patches:
The first patch adds missing ATA_CMD_* values which the legacy code will need.
The second patch updates the legacy code (and a couple of stragglers) to use the new ATA_CMD_* tokens.
The third patch removes the (then) redundant cruft from hdreg.h. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |