Messages in this thread |  | | Date | Fri, 5 Nov 2004 09:32:29 +0100 | | From | Stelian Pop <> | | Subject | Re: [PATCH RESEND] pcmcia network drivers cleanup |
| |
On Thu, Nov 04, 2004 at 09:25:20PM -0500, Jeff Garzik wrote:
> Stelian Pop wrote: > >Hi, > > > >The attached patch: > > * cleans up the parameter passing (module_param() instead of > > MODULE_PARM() > > * makes debugging work (PCMCIA_DEBUG does not exist anymore, make the > > Makefile test for CONFIG_PCMCIA_DEBUG and activate DEBUG in CFLAGS) > > and use the same debugging macros for every driver through code > > reuse. > > Comments: > > 1) Can you please separate module_param() and PCMCIA_DEBUG patches?
I will and resubmit later. The two changes were a bit related (modifying the debugging made me do the module_param() cleanup because MODULE_PARM() and module_param() aren't both allowed in the same module) that's why I originaly submitted a single patch.
> 2) why not use pr_debug()?
Because pr_debug doesn't take into account the verbosity level like pn_dbg() does. A lot of drivers in drivers/pcmcia/ do use such a construction...
Stelian. -- Stelian Pop <stelian@popies.net> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |