lkml.org 
[lkml]   [2004]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] change Kconfig entry for RAMFS (Was: Re: support of older compilers)
    On Fri, 5 Nov 2004, Linus Torvalds wrote:
    > On Fri, 5 Nov 2004, Grzegorz Kulewski wrote:
    >>
    >> And using ramfs for anything else can easily lead to similar problems. So
    >> I think we do not need ramfs. Am I wrong? [I understand that removing it
    >> will not remove much code.]
    >
    > ramfs is very useful as a minimal filesystem for showing what the VFS
    > interfaces are, and also (I believe) used in embedded environments, where
    > it's simply the smallest possible thing, and swap isn't available anyway.
    >
    > You can just disable it if you don't want it..

    Probably, but it looks like it does not display in menuconfig and it is
    set by default. I understand that it is a good example, but it should be
    disabled by default I think... Or at least it should show in menuconfig.
    And I do not know why embedded environments want to use ramfs more
    than tmpfs. Swap is not needed for tmpfs and even if device has no swap it
    can be oomed because of ramfs too.


    Will you accept this patch:

    Signed-off-by: Grzegorz Kulewski <kangur@polcom.net>

    --- linux/fs/Kconfig 2004-11-05 23:14:27.297548136 +0100
    +++ linux-gk/fs/Kconfig 2004-11-05 23:23:09.365181792 +0100
    @@ -929,8 +929,8 @@
    def_bool HUGETLBFS

    config RAMFS
    - bool
    - default y
    + bool "Ramfs file system support (PROBABLY USE TMPFS INSTEAD)"
    + default n
    ---help---
    Ramfs is a file system which keeps all files in RAM. It allows
    read and write access.
    @@ -939,8 +939,8 @@
    you need a file system which lives in RAM with limit checking use
    tmpfs.

    - To compile this as a module, choose M here: the module will be called
    - ramfs.
    + WARNING: If you will place too many data on this filesystem,
    + the kernel will panic because of OOM! Use tmpfs instead if you can.

    source "fs/supermount/Kconfig"

    -
    I think that RAMFS can not be build as a module becuse it is marked bool.
    Am I wrong?

    If you will apply this it will be my first kernel patch in mainline. Wow!
    :-)

    Because of this reason please do not complain too loud if something is
    not ok with this patch. I am inexperienced in producing and sending
    patches for inclusion into Linux. If this patch is broken or you do not
    want to apply it in this form, I will be more than happy to fix it of
    course.


    Thanks,

    Grzegorz Kulewski

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:3.485 / U:0.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site