lkml.org 
[lkml]   [2004]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: patch for sysfs in the cyclades driver
On Thu, Nov 04, 2004 at 11:05:40AM -0800, Roland Dreier wrote:
> Roland> I assume this is OK (since there is already one in-kernel
> Roland> driver doing it), but Greg, can you confirm that it's
> Roland> definitely OK for a driver to use class_set_devdata() on a
> Roland> class_device from class_simple_device_add()?
>
> Greg> Hm, I think that should be ok, but I'd make sure to test it
> Greg> before verifying that it really is :)
>
> Well class_simple.c definitely doesn't use class_data/class_set_devdata()
> now (and as I said drivers/scsi/st.c is using this on a class_simple
> device). The question is whether you can bless this situation as part
> of the API, or whether some time in the future class_simple might
> start using class_data.

Hey, if it works today, great! If I, or someone else breaks this in the
future, they they will have to deal with the issue then :)

In short, use it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.048 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site