Messages in this thread | | | From | Blaisorblade <> | Subject | Re: [uml-user] [PATCH] extend the limits for command line | Date | Thu, 4 Nov 2004 15:34:19 +0100 |
| |
On Thursday 04 November 2004 08:08, Catalin(ux aka Dino) BOIE wrote: > Hello! > > (I resend this because I get no feedback.) Sorry, miss of time.
> Testing UML on my project, I hit the limit for command line with something > like this:
> default \ > mem=64M \ > ubda=COW,/data/UML4/roots/ROOT1 \ > ubdb=SWAP \ > ubdc=CONF.tar \ > ${HSSTR} \ > eth0=daemon,fe:fd:39:bd:cc:d7,,/data/UML4/conf/example1/socks/SW1 > eth1=daemon,fe:fd:01:01:01:12,,/data/UML4/conf/example1/socks/SW2 > eth2=daemon,fe:fd:01:01:01:99,,/data/UML4/conf/example1/socks/SW4 > eth3=daemon,fe:fd:01:01:01:03,,/data/UML4/conf/example1/socks/SW5 > eth4=daemon,fe:fd:01:01:01:04,,/data/UML4/conf/example1/socks/SW6 > eth5=daemon,fe:fd:01:01:01:81,,/data/UML4/conf/example1/socks/SW8p1 > eth6=daemon,fe:fd:3f:a9:35:e2,,/data/UML4/conf/EXTERN/E1 \ > con=null \ > ssl0=port:9101 \ > umid=example1-pc1 \ > @pc1@
> Patch to extend the limits (buffer and number of args/envs) is attached. > Please consider including it because UML is intended to be run with such > long lines. > I'm open to other alternatives as a Kconfig entry for this.
> Thank you!
> Signed-off-by: Catalin(ux aka Dino) BOIE <catab at umbrella dot ro>
The idea of the patch is correct.
The UML part should be mergeable immediately - however, I don't know if that could be a security risk or has any bug (any place still using the old size).
Also, I'd like to understand what arch/um/kernel/user_util.c wants to do near its beginning!
For the arch-independent code, there needs to be something like a Kconfig entry (not necessarily a user-question, see CONFIG_GENERIC_RWSEM for instance).
Also, I'd like to cross-check this patch with the one used by Knoppix for ages to do the same thing.
Bye -- Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 [unhandled content-type:application/pgp-signature] | |