Messages in this thread | | | Date | Tue, 30 Nov 2004 22:44:37 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH] net/via-rhine: convert MODULE_PARM to module_param |
| |
On Tue, 30 Nov 2004, Roger Luethi wrote:
> On Tue, 30 Nov 2004 00:58:58 +0100, Jesper Juhl wrote: > > These warnings told me that it was time to move to module_param() :) > > > > drivers/net/via-rhine.c:229: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562) > > drivers/net/via-rhine.c:230: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562) > > drivers/net/via-rhine.c:231: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562) > > > > So I made this small patch to do so. > > Compile and boot tested on my box, and it seems to work just fine, the > > module works perfectly with my via-rhine card, and the parameters are > > exposed through sysfs as expected : > > IIRC Jeff has already queued such a patch for 2.6.11.
Hmm, ok. I assume that's what's currently in -mm - I haven't been following -mm lately so I missed the fact that the driver in there had already moved to module_param(). There's one difference though, and I think it matters; my patch sets the permission bits so that the parameters get exposed in sysfs (which I think is very useful), the driver in -mm sets the perms to 0 (zero) so nothing is exposed in sysfs (less useful).
>Thanks, though.
You are very welcome.
-- Jesper Juhl
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |