lkml.org 
[lkml]   [2004]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] move OSS ac97_codec.h to sound/oss/
    Alan Cox wrote:
    > On Maw, 2004-11-30 at 01:37, Al Viro wrote:
    >
    >>On Tue, Nov 30, 2004 at 02:31:39AM +0100, Adrian Bunk wrote:
    >>
    >>>As far as I can see, there's no good reason why the OSS ac97_codec.h
    >>>lives in include/linux/ .
    >>
    >>Except for a bunch of constants defined there. Are you sure that they
    >>are not exposed to userland?
    >
    >
    > OSS never really exposed raw AC97 to user space. Probably it should have
    > for the whacky corner cases and for stuff like AC97 digitizers.
    >
    > Acked-by: Alan Cox <alan@redhat.com>

    Disagreement-from: Jeff Garzik <jgarzik@pobox.com>


    The reason why ac97_codec.h is in include/linux is because it provides a
    __public interface__.

    Adrian's change

    (a) makes it difficult to work on OSS drivers outside sound/oss

    (b) increases the pain level of keeping 2.4 and 2.6 drivers in sync --
    something that I am doing to i810_audio at least.

    ac97_codec.h should stay where it is, until OSS drivers are removed from
    the tree.

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.023 / U:0.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site