Messages in this thread | | | Date | Mon, 29 Nov 2004 11:07:20 -0800 | From | Greg KH <> | Subject | Re: [PATCH] fix unnecessary increment in firmware_class_hotplug() |
| |
On Fri, Nov 26, 2004 at 09:30:24PM +0100, Marcel Holtmann wrote: > Hi Keiichiro, > > > This patch is to fix unnecessary increment of 'i' used to > > specify an element of an arry 'envp[]' in firmware_class_hotplug(). > > The 'i' is already incremented in add_hotplug_env_var(), actually. > > you are right. The incrementation is wrong, but it doesn't have any > negative effect. However the same applies for the usb_hotplug() function > in drivers/usb/core/usb.c. > > > Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com> > > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Applied, thanks.
greg k-h
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |