lkml.org 
[lkml]   [2004]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] sstfb.c: make some code static
On Wed, Nov 24, 2004 at 10:49:47PM +0000, Alan Cox wrote:
> On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote:
> > The patch below makes some needlessly global code static.
>
> No it doesn't. It makes some functions static (which is fine) and adds
> some nasty messy pointless #ifdefs. It touches no variable at all.
>
> Please check your description texts and also don't fill the kernel with
> ifdef crap. Probably the __setup stuff should be a module param new
> style too.

Yes, the description text could have been better.

The "ifdef crap" comes from the fact, that after making the functions
static, gcc warns if they are unused.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.036 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site