lkml.org 
[lkml]   [2004]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH]: 1/4 batch mark_page_accessed()
    Marcelo Tosatti writes:
    >
    > Hi Nikita,

    Hello, Marcelo,

    >

    [...]

    > > + if (pagezone != zone) {
    > > + if (zone)
    > > + local_unlock_irq(&zone->lru_lock);
    >
    > You surely meant spin_{un}lock_irq and not local{un}lock_irq.

    Oh, you are right. local_lock_* are functions to manipulate "local wait"
    spin-lock variety that was introduced by some other
    patch. batch-mark_page_accessed patch worked only because all references
    to local_lock_* functions were removed by pvec-cleanup patch.

    Another proof of the obvious fact that manually coded pagevec iteration
    is evil. :)

    >
    > Started the STP tests on 4way/8way boxes.

    Great.

    Nikita.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.022 / U:0.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site