lkml.org 
[lkml]   [2004]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Suspend 2 merge: 10/51: Exports for suspend built as modules.
    >  /*
    > * Platforms implementing 32 bit compatibility ioctl handlers in
    > - * modules need this exported
    > + * modules need this exported. So does Suspend2 (when made as
    > + * modules), so the export_symbol is now unconditional.
    > */
    > -#ifdef CONFIG_COMPAT
    > EXPORT_SYMBOL(sys_ioctl);
    > -#endif

    This is definitly the wrong interface for whatever you want to do.

    > diff -ruN 400-exports-old/fs/namei.c 400-exports-new/fs/namei.c
    > --- 400-exports-old/fs/namei.c 2004-11-03 21:53:11.000000000 +1100
    > +++ 400-exports-new/fs/namei.c 2004-11-04 16:27:40.000000000 +1100
    > @@ -1649,6 +1649,8 @@
    > return error;
    > }
    >
    > +EXPORT_SYMBOL(sys_mkdir);

    Dito

    > * We try to drop the dentry early: we should have
    > * a usage count of 2 if we're the only user of this
    > diff -ruN 400-exports-old/fs/namespace.c 400-exports-new/fs/namespace.c
    > --- 400-exports-old/fs/namespace.c 2004-11-03 21:54:15.000000000 +1100
    > +++ 400-exports-new/fs/namespace.c 2004-11-04 16:27:40.000000000 +1100
    > @@ -490,6 +490,8 @@
    > return retval;
    > }
    >
    > +EXPORT_SYMBOL(sys_umount);

    Dito

    > +EXPORT_SYMBOL(sys_mount);

    Dito.

    > +EXPORT_SYMBOL(proc_match);

    Also nothing anything outside of procfs internals should do.

    > +EXPORT_SYMBOL(sys_write);

    wrong aswell.

    > +EXPORT_SYMBOL(sys_reboot);

    Dito

    > unsigned long avenrun[3];
    > +EXPORT_SYMBOL(avenrun);

    Nothing you should poke into.

    > +/* Exported for Software Suspend 2 */
    > +EXPORT_SYMBOL(nr_free_highpages);
    > +EXPORT_SYMBOL(pgdat_list);

    Dito.

    > +EXPORT_SYMBOL(swap_free);
    > +EXPORT_SYMBOL(swap_info);
    > +EXPORT_SYMBOL(sys_swapoff);
    > +EXPORT_SYMBOL(sys_swapon);
    > +EXPORT_SYMBOL(si_swapinfo);
    > +EXPORT_SYMBOL(map_swap_page);
    > +EXPORT_SYMBOL(get_swap_page);
    > +EXPORT_SYMBOL(get_swap_info_struct);

    Dito. Lowlevel swapdevice access isn't something modules should poke
    into.

    Nigel, why do I have this strange feeling that exactly the same patch
    was rejected already but you resubmitted it again?

    If you want anything merged drop the modular swsusp bits, I doubt it'll
    ever be merged.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.028 / U:29.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site