Messages in this thread | | | Date | Wed, 24 Nov 2004 04:02:08 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] small drivers/atm cleanups (fwd) |
| |
On Tue, Nov 23, 2004 at 06:09:31PM -0800, Andrew Morton wrote: > Adrian Bunk <bunk@stusta.de> wrote: > > > > /* > > - * This routine will clock the Read_Status_reg function into the X2520 > > - * eeprom, then pull the result from bit 16 of the NicSTaR's General Purpose > > - * register. > > - */ > > - > > -u_int32_t > > -nicstar_read_eprom_status( virt_addr_t base ) > > I'd be inclined to whack an #if 0 around functions such as this rather than > removing them. Someone may come along one day and do some work on the > driver, and nicstar_read_eprom_status() may prove to be useful to them. >...
In this case, you also have to #if 0 rdsrtab.
Are you editing my patch or shall I send an updated patch?
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |