Messages in this thread | | | Date | Tue, 23 Nov 2004 14:27:12 -0500 | From | Jeff Mahoney <> | Subject | Re: [PATCH 2/5] selinux: adds a private inode operation |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Chris Wright wrote: | * Jeff Mahoney (jeffm@suse.com) wrote: | |>Excellent. Thanks. Preliminary testing works as expected (ie: deadlocks |>don't occur, xattrs/<dir> is removed when owning file is deleted) |> |>I've integrated the changes into my patch set. With those issues |>addressed, would you feel these would be appropriate for inclusion? I |>suspect you may have gotten questions as many interested parties in this |>feature working as I have. | | | Why add extra hook, when this could be done in VFS with i_flags?
Sure, it could be done w/ an i_flags bit. However, since it's explicitly related to the security infrastructure, I think it's more appropriate there. There's no change in the size of inode_security_struct, and the addition of the deref is trivial given how many other places in the file-io path use the same call table. That said, I'll change it to use whatever ends up being agreed upon. I'm just looking to get selinux to not call xattr routines on reiserfs-internal files/directories.
- -Jeff
- -- Jeff Mahoney SuSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBo48QLPWxlyuTD7IRAiIlAJ9wN7JPywCVz/UVJ1dVTM1kQphPRQCgoK8J TMDL9KrBABk49cbfN7AcoOA= =6RPR -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |