Messages in this thread | | | Date | Mon, 22 Nov 2004 17:09:55 +0100 | From | Johannes Stezenbach <> | Subject | Re: [linux-dvb-maintainer] [patch] 2.6.10-rc2-mm3: DVB: philips_tdm1316l_config multiple definition |
| |
On Mon, Nov 22, 2004 at 04:51:23PM +0100, Adrian Bunk wrote: > On Sun, Nov 21, 2004 at 10:39:29PM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.10-rc2-mm2: > >... > > +dvb-follow-frontend-changes-in-drivers.patch > >... > > +dvb-follow-changes-in-dvb-ttpci-and-budget-drivers.patch > > > > Big DVB update > >... > > <-- snip --> > > ... > LD drivers/media/dvb/built-in.o > drivers/media/dvb/ttusb-budget/built-in.o(.data+0x3364): multiple > definition of `philips_tdm1316l_config' > drivers/media/dvb/ttpci/built-in.o(.data+0x8c8): first defined here > make[3]: *** [drivers/media/dvb/built-in.o] Error 1 > > <-- snip --> > > > Since none of them has a good reason for being global, the patch below > makes both static.
Thanks, patch applied to linuxtv.org CVS.
BTW, like I said in some previous mail I think this "Big DVB update" isn't ready for prime time yet. It breaks support for some DVB cards (partially fixed in linuxtv.org CVS), so I think this should not go into the mainline kernel now. IMHO it's better to wait until 2.6.10 is out.
Michael: Do you think differently?
Johannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |