lkml.org 
[lkml]   [2004]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] add list_del_head function
    On Sat, Nov 20 2004, Tobias DiPasquale wrote:
    > Hi all,
    >
    > I was working with some queues the other day and I noticed that there
    > was a list_add_tail() function in list.h, but no list_del_head()
    > function. This struck me as a little odd, so I went ahead and
    > implemented one in order to complete full queue functionality. The
    > patch below was generated against pristine 2.6.9 kernel.org kernel
    > sources and is attached to this email.

    Generally patches like this have little merrit unless accompanied by
    another patch converting several obvious pieces of kernel code to use
    it.

    Also I find the interface awkward and different from the other list
    functions.

    entry = list_del_head(list);

    would have been much nicer.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.019 / U:163.468 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site