lkml.org 
[lkml]   [2004]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [discuss] Re: RFC: let x86_64 no longer define X86
    On Fri, Nov 19, 2004 at 05:21:22AM -0500, Jeff Garzik wrote:
    > Andi Kleen wrote:
    > >On Fri, Nov 19, 2004 at 01:51:17AM +0100, Adrian Bunk wrote:
    > >
    > >>I'd like to send a patch after 2.6.10 that removes the following from
    > >>arch/x86_64/Kconfig:
    > >>
    > >> config X86
    > >> bool
    > >> default y
    > >
    > >
    > >I'm against this. Please don't do this.
    >
    > An explanation would be nice.

    Basically what Paul Menage said. There is a lot of common code,
    and you would end up writing X86 && X86_64 more often than
    X86 && !X86_64.

    In addition such a change is quite intrusive and I don't
    think it's a good idea to do right now because it'll very
    likely introduce bugs.

    If someone really thinks the X86 && !X86_64 is too ugly
    (I personally don't think it is because it says clearly
    what the matter is) then adding an additional X86_32 would be the right
    thing to do.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.022 / U:63.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site