Messages in this thread | | | Subject | Re: [patch] inotify: use permission not vfs_permission | From | John McCutchan <> | Date | Wed, 17 Nov 2004 19:59:44 -0500 |
| |
This looks good. Thanks.
On Wed, 2004-11-17 at 15:28 -0500, Robert Love wrote: > On Wed, 2004-11-17 at 15:25 -0500, Mike Waychison wrote: > > > permission() still takes 3 arguments though. I think it is safe to pass > > NULL for the nameidata. > > Ugh, I compile-tested the wrong tree. Thanks. > > It is safe to pass NULL. > > Patch below. > > Robert Love > > > Use permission() instead of generic_permission(). > > Signed-Off-By: Robert Love <rml@novell.com> > > diff -u linux/drivers/char/inotify.c linux/drivers/char/inotify.c > --- linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500 > +++ linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500 > @@ -166,7 +166,7 @@ > inode = nd.dentry->d_inode; > > /* you can only watch an inode if you have read permissions on it */ > - error = vfs_permission(inode, MAY_READ); > + error = permission(inode, MAY_READ, NULL); > if (error) { > inode = ERR_PTR(error); > goto release_and_out; > > -- John McCutchan <ttb@tentacle.dhs.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |