Messages in this thread Patch in this message | | | Date | Wed, 17 Nov 2004 15:25:26 -0500 | From | Mike Waychison <> | Subject | Re: [patch] inotify: use permission not vfs_permission |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Robert Love wrote: > On Wed, 2004-11-17 at 15:09 -0500, Mike Waychison wrote: > > >>use permission() > > > I appreciate the constructive comment. > > John, attached patch replaces vfs_permission() with permission(). > > Thanks, Mike. > > Robert Love > > > Use permission() instead of generic_permission(). > > Signed-Off-By: Robert Love <rml@novell.com> > > diff -u linux/drivers/char/inotify.c linux/drivers/char/inotify.c > --- linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500 > +++ linux/drivers/char/inotify.c 2004-11-17 12:28:27.921136656 -0500 > @@ -166,7 +166,7 @@ > inode = nd.dentry->d_inode; > > /* you can only watch an inode if you have read permissions on it */ > - error = generic_permission(inode, MAY_READ, NULL); > + error = permission(inode, MAY_READ); > if (error) { > inode = ERR_PTR(error); > goto release_and_out; > >
permission() still takes 3 arguments though. I think it is safe to pass NULL for the nameidata.
- -- Mike Waychison Sun Microsystems, Inc. 1 (650) 352-5299 voice 1 (416) 202-8336 voice
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOTICE: The opinions expressed in this email are held by me, and may not represent the views of Sun Microsystems, Inc. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBm7O2dQs4kOxk3/MRApYgAJ0c1XGD99i8Yir2LYTAtosJrOtvIACfT5BE C3T8DDq+L9NskVe1sI47IKM= =BZA8 -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |