Messages in this thread | | | From | "Antonino A. Daplas" <> | Subject | Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb | Date | Sun, 14 Nov 2004 05:29:46 +0800 |
| |
On Sunday 14 November 2004 02:00, Linus Torvalds wrote: > On Sat, 13 Nov 2004, Antonino A. Daplas wrote: > > Why not use in_be* and out_be* for __raw_read and raw_write? > > Please don't start using some stupid magic ppc-specific macros for a > driver that has no reason to be PPC-specific. It then only causes bugs > that show on one platform and not another.
I'm not. I'm just wondering that if the other approach was taken (keep the hardware in little endian mode), then the write/read* macros, which are just wrappers for in_le*/out_le*, would have been used. Would it help fix (or cover up) bugs that are in PPC but not x86?
Tony
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |