lkml.org 
[lkml]   [2004]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
    From
    Date
    On Sun, 2004-11-14 at 05:29 +0800, Antonino A. Daplas wrote:
    > On Sunday 14 November 2004 02:00, Linus Torvalds wrote:
    > > On Sat, 13 Nov 2004, Antonino A. Daplas wrote:
    > > > Why not use in_be* and out_be* for __raw_read and raw_write?
    > >
    > > Please don't start using some stupid magic ppc-specific macros for a
    > > driver that has no reason to be PPC-specific. It then only causes bugs
    > > that show on one platform and not another.
    >
    > I'm not. I'm just wondering that if the other approach was taken (keep the
    > hardware in little endian mode), then the write/read* macros, which are just
    > wrappers for in_le*/out_le*, would have been used. Would it help fix (or
    > cover up) bugs that are in PPC but not x86?

    If you switch the HW to LE, I'm afraid you'll lockup when VT switching
    back & forth with X ...

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.018 / U:34.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site