Messages in this thread | | | Subject | RE: [PATCH] handle quoted module parameters | Date | Fri, 12 Nov 2004 12:02:10 -0700 | From | <> |
| |
Hello Randy,
Thanks for your two responses!
Based on your patch, the format of argument will be changed from standard format before: Used to be: modprm1=first,ext modprm2=second,ext modprm3="third1,ext third2,ext" where the quotation in modprm3 represents the whole string, including space, to be the value of third parameter modprm3.
Now the patch changes modprm3 to "modprm3=third1,ext third2,ext" which equivalent to putting quotation mark on normal parameter define "modprm1=first,ext". Do you think linux community will take that change?
Another question is the parameter length is not limited in 2.4.x kernel. Why this is restricted under 2.6.x. (param_set_charp())?
Regards,
Eddie
-----Original Message----- From: Randy.Dunlap [mailto:rddunlap@osdl.org] Sent: Thursday, November 11, 2004 8:17 PM To: Randy.Dunlap Cc: yiding_wang@agilent.com; arjan@infradead.org; linux-kernel@vger.kernel.org; rusty@rustcorp.com.au; akpm Subject: [PATCH] handle quoted module parameters
Here's a patch with better description.
Fix module parameter quote handling. Module parameter strings (with spaces) are quoted like so: "modprm=this test" and not like this: modprm="this test"
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:= kernel/params.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-)
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |