lkml.org 
[lkml]   [2004]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [PATCH] kmem_alloc (generic wrapper for kmalloc and vmalloc)
    Robert Love schrieb:
    > On Wed, 2004-11-10 at 06:19 +0100, Carl-Daniel Hailfinger wrote:
    >
    >>Hi,
    >>
    >>it seems there is a bunch of drivers which want to allocate memory as
    >>efficiently as possible in a wide range of allocation sizes. XFS and
    >>NTFS seem to be examples. Implement a generic wrapper to reduce code
    >>duplication.
    >>Functions have the my_ prefixes to avoid name clash with XFS.
    >
    >
    > No, no, no. A good patch would be fixing places where you see this.
    >
    > Code needs to conscientiously decide to use vmalloc over kmalloc. The
    > behavior is different and the choice needs to be explicit.

    Yes, but what do you suggest for the following problem:
    alloc(max_loop*sizeof(struct loop_device))

    where sizeof(struct loop_device)==304 and 1<=max_loop<=16384

    For the smallest allocation (304 bytes) vmalloc is clearly wasteful
    and for the largest allocation (~ 5 MBytes) kmalloc doesn't work.


    Regards,
    Carl-Daniel
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:4.960 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site