lkml.org 
[lkml]   [2004]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.10-rc1-mm4
Thomas Schlichter <thomas.schlichter@web.de> wrote:
>
> Today I tested the linux-2.6.10-rc1-mm4 kernel and it works fine with the
> attached config. But if I enable HIGHPTE, that kernel hits following BUG
> (written down by hand) and panics when the INIT process is started:
>
> kernel BUG at arch/i386/mm/highmem.c:63!
> EIP is at kunmap_atomic+0x27/0x70
> Call Trace
> show_stack+0xa6/0xb0
> show_register+0x14d/0x1c0
> die+0x158/0x2e0
> do_invalid_op+0xef/0x100
> error_code+0x2b/0x30
> copy_pte_range+0x122/0x490

This might help:




We're modifying src_pte and dst_pte in the for-loop, and then unmapping the
modified pointers. If one of them walked off the end of the page then blam.


Signed-off-by: Andrew Morton <akpm@osdl.org>
---

25-akpm/mm/memory.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)

diff -puN mm/memory.c~4level-highpte-fix mm/memory.c
--- 25/mm/memory.c~4level-highpte-fix Wed Nov 10 14:58:55 2004
+++ 25-akpm/mm/memory.c Wed Nov 10 15:00:58 2004
@@ -332,7 +332,8 @@ static int copy_pte_range(struct mm_stru
struct vm_area_struct *vma,
unsigned long addr, unsigned long end)
{
- pte_t * src_pte, * dst_pte;
+ pte_t *src_pte, *dst_pte;
+ pte_t *s, *d;
unsigned long vm_flags = vma->vm_flags;

dst_pte = pte_alloc_map(dst_mm, dst_pmd, addr);
@@ -341,12 +342,12 @@ static int copy_pte_range(struct mm_stru

spin_lock(&src_mm->page_table_lock);
src_pte = pte_offset_map_nested(src_pmd, addr);
- for (;
- addr < end;
- addr += PAGE_SIZE, src_pte++, dst_pte++) {
- if (pte_none(*src_pte))
+ d = dst_pte;
+ s = src_pte;
+ for ( ; addr < end; addr += PAGE_SIZE, s++, d++) {
+ if (pte_none(*s))
continue;
- copy_one_pte(dst_mm, src_mm, dst_pte, src_pte, vm_flags, addr);
+ copy_one_pte(dst_mm, src_mm, d, s, vm_flags, addr);
}
pte_unmap_nested(src_pte);
pte_unmap(dst_pte);
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.076 / U:23.716 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site