Messages in this thread | | | Date | Mon, 1 Nov 2004 11:34:58 +0000 | From | Russell King <> | Subject | Re: [patch] PCI: Add is_bridge to pci_dev to allow fixups to disable bridge functionality. |
| |
On Mon, Nov 01, 2004 at 10:59:13AM +0000, David Vrabel wrote: > Greg KH wrote: > > On Tue, Oct 19, 2004 at 12:22:49PM +0100, David Vrabel wrote: > > > >>The plan was to make the CardBus driver (drivers/pcmcia/yenta_socket.c) > >>honour the is_bridge flag and not bother with CardBus stuff if it's cleared. > > > > But why can't any code that wants to check this, just look at the > > dev->hdr_type instead? I don't think we need to add a new bit for this > > because of that, right? > > Using the is_bridge flag allows PCI device fixups to disable the CardBus > portion of the driver. And you obviously can't tweak the hdr_type since > the device header is still a CardBus/bridge type header.
Why not make the PCI spaces for cardbus bridges configurable? Eg,
cardbusmem=1M cardbusio=8K
?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |