Messages in this thread | | | From | Keith Owens <> | Subject | Re: [PATCH] Make gcc -align options .config-settable | Date | Fri, 08 Oct 2004 15:03:19 +1000 |
| |
On Fri, 1 Oct 2004 15:17:51 -0700, Andrew Morton <akpm@osdl.org> wrote: >Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote: >> >> With all alignment options set to 1 (minimum alignment), >> I've got 5% smaller vmlinux compared to one built with >> default code alignment. >> > >Sam, can you process this one? > >> >> >> +GCC_VERSION = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC)) > >It bugs me that we're evaluating the same thing down in arch/i386/Makefile. > Perhaps we should evaluate GCC_VERSION once only, as some top-level kbuild >thing. So everyone can assume that it's present and correct?
Using '=' is wrong here, it will evaluate the complete expression every time GCC_VERSION is tested. It should be ':='. The only time '=' should be used in a Makefile is when delayed evaluation is really required, e.g. for strings that are the target of $(call).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |