Messages in this thread | | | Date | Tue, 5 Oct 2004 23:16:42 -0700 | From | Andrew Morton <> | Subject | Re: Preempt? (was Re: Cannot enable DMA on SATA drive (SCSI-libsata, VIA SATA)) |
| |
Jeff Garzik <jgarzik@pobox.com> wrote: > > Andrew Morton wrote: > > Jeff Garzik <jgarzik@pobox.com> wrote: > > > >>Preempt will always be something I ask people to turn off when reporting > >> driver bugs; it just adds too much complicated mess for zero gain. > > > > > > What driver bugs are apparent with preemption which are not already SMP bugs? > > If your implied answer is true, then we wouldn't need > preempt_{en,dis}able() sprinkled throughout the code so much. >
Where?
`grep -r preempt_disable drivers' points at one bodgy scsi driver.
`grep -r preempt_disable fs' finds two instances of per-cpu data.
`grep -r preempt_disable mm' finds three instances (wtf is vmalloc_to_page trying to do? Looks redundant)
`grep -r preempt_disable ipc' is empty
`grep -r preempt_disable net' is empty
`grep -r preempt_disable include' gets a few.
It's less than I expected, actually. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |