Messages in this thread | | | Date | Wed, 6 Oct 2004 11:19:58 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Console: fall back to /dev/null when no console is availlable |
| |
On Wed, Oct 06, 2004 at 08:04:21PM +0200, J?rn Engel wrote: > On Wed, 6 October 2004 10:38:23 -0700, Greg KH wrote: > > On Tue, Oct 05, 2004 at 08:52:14PM +0200, J?rn Engel wrote: > > > --- linux-2.6.8cow/init/main.c~console 2004-10-05 20:46:40.000000000 +0200 > > > +++ linux-2.6.8cow/init/main.c 2004-10-05 20:46:08.000000000 +0200 > > > @@ -695,8 +695,11 @@ > > > system_state = SYSTEM_RUNNING; > > > numa_default_policy(); > > > > > > - if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0) > > > + if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0) { > > > printk("Warning: unable to open an initial console.\n"); > > > + if (open("/dev/null", O_RDWR, 0) == 0) > > > + printk(" Falling back to /dev/null.\n"); > > > + } > > > > Your printk() calls need the proper KERN_* level. > > As does the original one. Which one would you like for both?
KERN_WARNING perhaps?
> > And what happens if you can't open /dev/null? > > Same as before. > > > (hint, udev enabled boxes > > usually do not have a /dev/null this early in the boot process). Does > > this mean we should add a /dev/null to the initramfs image, like the > > /dev/console node we currently have there? > > Yes, that would fix the case. Is this a problem?
I don't have a problem with doing that.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |