Messages in this thread | | | Date | Tue, 05 Oct 2004 13:20:32 -0500 | From | Patrick Gefre <> | Subject | Re: [PATCH] 2.6 SGI Altix I/O code reorganization |
| |
Luck, Tony wrote: > I'm ok with the delete/add of most of the SGI > specific files (maybe it still isn't perfect yet, > but it may be close enough to take it, and then > clean up with some small patches). > > But you seem to be touching some files outside of pure SGI > stuff. These two are a bit of a concern: > > include/asm-ia64/io.h
> arch/ia64/pci/pci.c >
Most of this is Lindent changes. The only mod is we need pci_root_ops to be non-static.
> These others are outside of my area (well I *might* push > the drivers that are only used by SGI ... but hotplug > and qla1280 are definitely not mine). So they need to be > split out into separate patches. >
As a general comment, the changes to these files are because of mods in the reorg code - so they are needed for this base but not in the older code. So, in my mind, it is a package - or should be taken as a whole. I can break them out, but I think they need to go together.
> drivers/char/mmtimer.c
This is Jesse's code. We made an include file change. Is this OK Jesse ?
> drivers/char/snsc.c
This is Greg Howard's code - he's reviewed and approved the mod. Should I add him as a signed-off ?
> drivers/ide/pci/sgiioc4.c
More Lindent mods. We took out the endian code - not needed anymore.
> drivers/pci/hotplug/Kconfig
Took out SGI PCI Hotplug. Since there isn't any code behind it - we will add it back in when we submit the code for it.
> drivers/scsi/qla1280.c
Again more Lindent mods. Took out the vchan definition hack.
> drivers/serial/sn_console.c >
This is my driver. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |