Messages in this thread | | | Date | Tue, 5 Oct 2004 10:47:44 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call |
| |
Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote: > > On Tue, Oct 05, 2004 at 10:18:23AM -0700, Andrew Morton wrote: > > Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote: > > > > > > Here is what I have come up with(please take a look at this patch). > > > I was successfully able to get rid of cpu_run_sbin_hotplug() function, but > > > when I call kobject_hotplug() function, it is finding > > > top_kobj->kset->hotplug_ops set to NULL and hence returns without calling > > > call_usermodehelper(). Not sure if this is a bug in kobject_hotplug(), > > > I feel kobject_hotplug() function should continue even if > > > top_kobj->kset-hotplug_ops is NULL. > > > > Yes, it doesn't seem necessary. We could give cpu_sysdev_class a > > valid-but-empty hotplug_ops but it seems simpler and more general to do it > > in kobject_hotplug(). > > I tried that, but I found that parent "cpu" directory i.e > /sys/devices/system/cpu itself was not getting created. Any clues?
I don't see why the change to kobject_hotplug() would cause that directory to not be created.
With your patch and mine applied, /sys/devices/system/cpu is present and populated on my test box.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |