Messages in this thread | | | Date | Tue, 5 Oct 2004 12:46:34 -0400 | From | Chuck Ebbert <> | Subject | Re: [Patch] new serial flow control |
| |
Samual Thibault wrote:
>+ } else if (info->flags & ASYNC_TVB_FLOW) { >+ if (status & UART_MSR_CTS) { >+ if (!(info->MCR & UART_MCR_RTS)) { >+ /* start of TVB frame, raise RTS to greet data */ >+ info->MCR |= UART_MCR_RTS; >+ serial_out(info, UART_MCR, info->MCR); >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW)) >+ printk("TVB frame start..."); >+#endif >+ } >+ } else { >+ if (info->MCR & UART_MCR_RTS) { >+ /* CTS went down, lower RTS as well */ >+ info->MCR &= ~UART_MCR_RTS; >+ serial_out(info, UART_MCR, info->MCR); >+#if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW)) >+ printk("TVB frame started..."); >+#endif ^^^^^^^
Shouldn't this be "ended"? ... or "end" since frame begin msg says "start" i.e. is not past tense?
--Chuck Ebbert - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |