lkml.org 
[lkml]   [2004]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 475] HP300 LANCE
    On Sun, 31 Oct 2004, Andrew Morton wrote:
    > Jeff Garzik <jgarzik@pobox.com> wrote:
    > >
    > > On Sun, Oct 31, 2004 at 02:48:40AM -0800, Andrew Morton wrote:
    > > > > - void *va = dio_scodetoviraddr(scode);
    > > > > + unsigned long pa = dio_scodetophysaddr(scode);
    > > > > + unsigned long va = (pa + DIO_VIRADDRBASE);
    > >
    > >
    > > > That's because the stoopid driver is using spaces instead of tabs all over
    > > > the place. It comes out visually OK once the patch is applied. But it's a
    > > > useful reminder of how much dreck we have in the tree.

    I did a big whitespace cleanup in arch/m68k a while ago, but I didn't dare to
    touch drivers/...

    > > Did you see the above quoted patch chunk? The patch is inconsistent
    > > with _itself_, adding 'pa' and 'va' with different idents (but when they
    > > should be at the same identation level).
    >
    > Trust me ;)
    >
    > http://www.zip.com.au/~akpm/linux/patches/stuff/x.jpg

    Yep, tabstops should be 1+n*8 (sometimes 2+n*8) instead of n*8 when looking at
    patches :-)

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.019 / U:63.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site