Messages in this thread | | | Date | Sun, 31 Oct 2004 01:19:12 +0200 | From | maximilian attems <> | Subject | Re: [KJ] Re: [patch 2.4] back port msleep(), msleep_interruptible() |
| |
On Sat, 30 Oct 2004, Nish Aravamudan wrote:
> On Sat, 30 Oct 2004 18:41:10 -0400, Jeff Garzik <jgarzik@pobox.com> wrote: > > maximilian attems wrote: > > > diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h > > > --- a/include/linux/delay.h~add-msleep-2.4 2004-10-30 22:48:46.000000000 +0200 > > > +++ b/include/linux/delay.h 2004-10-30 22:48:46.000000000 +0200 > > > @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy; > > > ({unsigned long msec=(n); while (msec--) udelay(1000);})) > > > #endif > > > > > > +void msleep(unsigned int msecs); > > > +unsigned long msleep_interruptible(unsigned int msecs); > > > + > > > +static inline void ssleep(unsigned int seconds) > > [...] > > > +static inline unsigned int jiffies_to_msecs(const unsigned long j) > > > > > +static inline unsigned int jiffies_to_usecs(const unsigned long j) > > > > > +static inline unsigned long msecs_to_jiffies(const unsigned int m) > > > > > > I'm pretty sure more than one of these symbols clashes with a symbol > > defined locally in a driver. I like the patch but we can't apply it > > until the impact on existing code is evaluated. > > More than likely much of the code cleanup that was done before I began > my patches, like removing custom msleep()s from drivers will need to > be done again, as Jeff points out. > > -Nish
thanks Jeff for your quick response, ooh i seee libata is defining an msleep(). so there seems to be need for it.
ok we'll come up with tougher patchset.
-- maks kernel janitor http://janitor.kernelnewbies.org/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |