Messages in this thread Patch in this message | | | Date | Wed, 27 Oct 2004 08:41:46 +0200 | From | Jens Axboe <> | Subject | Re: 2.6.9-mm1: LVM stopped working (dio-handle-eof.patch) |
| |
On Wed, Oct 27 2004, Jens Axboe wrote: > On Tue, Oct 26 2004, Andrew Morton wrote: > > Mathieu Segaud <matt@minas-morgul.org> wrote: > > > > > > Andrew Morton <akpm@osdl.org> disait dernièrement que : > > > > > > > If you have time, please restore dio-handle-eof.patch and then apply the > > > > below fixup, then retest. Thanks. > > > > > > I had time to test this fix; it did not solve the problem. Whereas reverting > > > the complete dio-handle-eof.patch solved it. > > > > bummer. Can you send a super-simple means by which I can demonstrate the > > problem? > > Hmm, maybe round the value up to a PAGE_SIZE in length?
This feels pretty icky, but should suffice for testing. Does it make a difference?
--- /opt/kernel/linux-2.6.10-rc1-mm1/fs/direct-io.c 2004-10-27 08:29:51.866931262 +0200 +++ linux-2.6.10-rc1-mm1/fs/direct-io.c 2004-10-27 08:41:20.292172299 +0200 @@ -987,8 +987,8 @@ isize = i_size_read(inode); if (bytes_todo > (isize - offset)) bytes_todo = isize - offset; - if (!bytes_todo) - return 0; + if (bytes_todo < PAGE_SIZE) + bytes_todo = PAGE_SIZE; for (seg = 0; seg < nr_segs && bytes_todo; seg++) { user_addr = (unsigned long)iov[seg].iov_base; -- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |