lkml.org 
[lkml]   [2004]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] remove highmem_start_page
From
Date
On Tue, 2004-10-26 at 17:23, Andrew Morton wrote:
> Dave Hansen <haveblue@us.ibm.com> wrote:
> >
> > +static inline int page_is_highmem(struct page *page)
> > +{
> > + return PageHighMem(page);
> > +}
>
> (boggle). Why not just use PageHighMem() directly?

Because I was doing another, more complex, calculation before that and
realized about PageHighMem() later on. Would have also made it easier
to fix if someone came up with a better way when I posted the patch :)
I take it you'd rather just see it called directly.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:1.193 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site