Messages in this thread | | | Date | Mon, 25 Oct 2004 19:02:16 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/17] Generic backward compatibility includes for 4level |
| |
On Mon, Oct 25, 2004 at 06:50:34PM +0200, Arjan van de Ven wrote: > > > > > > Don't we normally add do { } while (0) after empty macros which look like > > > a function? > > > > iirc Rusty tried to come up with an example some time ago where it actually > > made a difference, but failed. But I can change it. > > > if (foo) > bar(); > else > pml4_ERROR(x); > something_else();
Doesn't make any difference. Try it. With a double else it may make a difference, but that is extremly bad style imho and better resolved with a {}. Also you'll get a clear compile error.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |