lkml.org 
[lkml]   [2004]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/28] VFS: Remove (now bogus) check_mnt
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    Christoph Hellwig wrote:
    > On Mon, Oct 25, 2004 at 10:44:33AM -0400, Mike Waychison wrote:
    >
    >>check_mnt used to be used to see if a mountpoint was actually grafted or not
    >>to a namespace. This was done because we didn't support mountpoints being
    >>attached to one another if they weren't associated with a namespace. We now
    >>support this, so all check_mnt calls are bogus. The only exception is that
    >>pivot_root still requires all participants to exist within the same
    >>namespace.
    >
    >
    > did you audit the namespace code that it doesn't allow attachign to other
    > namespaces than the current?
    >

    So, I don't see how that is possible, other than through relative
    resolution from a cwd in the other namespace. Arguably, you aren't
    buying any security by denying the mountpoint if you already let other
    processes in your namespace.

    Auditting the original code, it appeared that doing such a thing was a
    no-no only because the locking semantics of current->namespace->sem made
    this difficult.


    - --
    Mike Waychison
    Sun Microsystems, Inc.
    1 (650) 352-5299 voice
    1 (416) 202-8336 voice

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    NOTICE: The opinions expressed in this email are held by me,
    and may not represent the views of Sun Microsystems, Inc.
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.2.5 (GNU/Linux)
    Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

    iD8DBQFBfRiVdQs4kOxk3/MRAmC2AJ93Dqcf1hNFjmjKESxsfuBeUqZ+nQCffEZX
    Ej3a3wyhQAwTg+amwHqn1v0=
    =se6H
    -----END PGP SIGNATURE-----
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.027 / U:29.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site