lkml.org 
[lkml]   [2004]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Realtime LSM
* Jack O'Quin (joq@io.com) wrote:
> Chris Wright <chrisw@osdl.org> writes:
>
> > - less generic variable names
> > - s/any/rt_any/
> > - s/gid/rt_gid/
> > - s/mlock/rt_mlock/
>
> Is there a compelling reason for changing all the parameter names?

primarly for namespace cleanliness. nice to avoid overly generic names
if possible. makes it easier to search.

> I would prefer not to do that. It is incompatible for our current
> user base, and really does not seem like an improvement. Those names
> only appear in the context of `realtime', so the `rt_' is completely
> redundant. For example...

Actually, I recall the change being 100% internal (not exposed
externally), but I'm away at the moment, so it's just from memory.

> # modprobe realtime gid=29
> # sysctl -w security/realtime/mlock=0
>
> Also, you forgot to update the documentation.

I don't think it was needed due to above.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.760 / U:1.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site