lkml.org 
[lkml]   [2004]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI fixes for 2.6.9
    On Wed, Oct 20, 2004 at 09:10:45AM +0100, Russell King wrote:
    > On Tue, Oct 19, 2004 at 03:42:15PM -0700, Greg KH wrote:
    > > ChangeSet 1.1997.37.29, 2004/10/06 12:50:32-07:00, kaneshige.kenji@jp.fujitsu.com
    > >
    > > [PATCH] PCI: warn of missing pci_disable_device()
    > >
    > > As mentioned in Documentaion/pci.txt, pci device driver should call
    > > pci_disable_device() when it decides to stop using the device. But
    > > there are some drivers that don't use pci_disable_device() so far.
    >
    > No. This is wrong. There are some classes of devices, notably
    > PCMCIA Cardbus drivers where buggy BIOS means this should _NOT_
    > be done.

    But what happens if you reload that driver and try to enable the device?
    Does that "just work" somehow on this kind of hardware?

    > There are BIOSen out there which refuse to suspend/resume if the
    > Cardbus bridge is disabled.
    >
    > It's not that the driver is buggy. It's that the driver has far
    > more information than the PCI layer could ever have.

    Ugh, I hate broken hardware. I'll revert this in my next round of pci
    changes (sometime next week.)

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [from the cache]
    ©2003-2011 Jasper Spaans