lkml.org 
[lkml]   [2004]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix recently introduced race in IBM PPC4xx I2C driver
On Tue, Oct 19, 2004 at 11:26:33PM -0700, Eugene Surovegin wrote:
> On Tue, Oct 19, 2004 at 10:21:08PM -0700, Eugene Surovegin wrote:
>
> [snip]
>
> > It looks like this change added race I tried to avoid here.
> >
> > This code is modeled after __wait_event_interruptible_timeout, where
> > "prepare_to_wait" is done _before_ checking completion status. This
> > change breaks this, e.g. if IRQ happens right after we check iic->sts,
> > but before calling msleep_interruptible(). In this case we'll sleep
> > much more than required (seconds instead of microseconds)
> >
> > Greg, if my analysis is correct, please rollback this change.
> >
> > Nishanth, I'd be nice if you CC'ed me with this patch, my e-mail is at
> > the top of that source file.
>
> Oh, well. I should have used wait_event_interruptible_timeout when I
> ported this driver to 2.6.
>
> This patch fixes recently introduced race and also cleans ups some
> 2.4-ism.
>
> Please, apply.

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.050 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site