Messages in this thread Patch in this message | | | Subject | Re: [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U9 | From | Thomas Gleixner <> | Date | Fri, 22 Oct 2004 17:57:53 +0200 |
| |
On Fri, 2004-10-22 at 17:15, K.R. Foley wrote: > Thomas Gleixner wrote: > > On Fri, 2004-10-22 at 16:12, K.R. Foley wrote: > > > >>I am not sure why the tulip driver is being loaded,unloaded,reloaded > >>every time on boot? Anyway, I wanted to check to see if I could generate > >>the above bug on subsequent unloads of the module. I downed the network > >>and the unloaded the tulip module. I did get the message below when > >>unloading the module but no "BUG: atomic counter underflow" message. > >> > >>Oct 22 05:43:33 porky kernel: tulip 0000:04:0a.0: Device was removed > >>without properly calling pci_disable_device(). This may need fixing. > >>Oct 22 05:43:33 porky net.agent[921]: remove event not handled > > > > > > Can you please verify this against vanilla 2.6.9 and 2.6.9-mm1 ? > > > > tglx > > > > I will verify it against 2.6.9 when I get time. I did verify the "Device > was removed without properly calling pci_disable_device(). This may need > fixing." message is generated with 2.6.9-rc3-mm3 without preempt > patches. Also thanks to Mark Johnson's suggestion I verified that the > reason the driver is being loaded twice is because kudzu is loading it > once then unloading it. > > kr
--- 2.6.9-rc4-mm1/drivers/net/tulip/tulip_core.c 2004-10-12 09:41:27.000000000 +0200 +++ 2.6.9-rc4-mm1-U9-E0/drivers/net/tulip/tulip_core.c 2004-10-22 17:54:31.000000000 +0200 @@ -1784,6 +1784,7 @@ #endif free_netdev (dev); pci_release_regions (pdev); + pci_disable_device (pdev); pci_set_drvdata (pdev, NULL); /* pci_power_off (pdev, -1); */
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |