lkml.org 
[lkml]   [2004]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Make drivers/char/mem.c use remap_pfn_range()


On Fri, 22 Oct 2004, William Lee Irwin III wrote:
>
> What I posted shifted the correct argument, though vma->vm_pgoff would
> have been been better, as it shifted offset right by PAGE_SHIFT, where
> offset could have overflowed. I have no idea what you're referring to
> about shifting the wrong argument.

Ok, that patch just got lost.

Quite as well, actually. The whole point of changing remap_page_range() to
remap_pfn_range() is to give the full range of page frame numbers, and
just shifting "offset" back down thus seems to be a bug to me. Otherwise
we migth as well just have continued with the old code.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.039 / U:27.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site