lkml.org 
[lkml]   [2004]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PROBLEM : Thread signal informations are not freed when it is execing.
From
Date
Le ven 22/10/2004 à 11:17, Roland McGrath a écrit :
> I don't think these problems are still relevant to the current sources,
> though some of them might still occur in 2.6.9. The fix I posted for the
> semantics bugs of exec vs pending signals makes de_thread not abandon the
> old signal_struct at all, so it holds on to all the data structures. If
> you can reproduce any kind of leak using the code now in Linus's tree,
> please show me the details.

I didn't find the post you're talking about, but after reading 2.6.9
de_thread function, I didn't find major diff with previous release.
So I suppose that the leak is always present, and I have some details..

I wrote a new test case that works with 2.6.x kernel. I have run it on a
Fedora Core 2 node with a 2.6.8-1.521 kernel and also with the new 2.6.9
kernel, and it has also produce a leak in siqueue buffers. It can be
seen by looking at sigqueue cache info in /proc/slabinfo.

It seems that the bug is due to the call to
init_sigpending(&current->pending) at line 737 of de_thread.
It breaks the actual sigqueue pending list and all the linked entries
are lost. As a consequence, current->user->pending count is also not
updated.

Here is the new test case. Of course you have to compile it with
-lpthread flag.

/*
* This small program generate a memory leak of signal info structure.
*
* The first time the test program is executed, it will send about 1024
* signal depending of RLIMIT_SIGPENDING value (default is 1024).
* Then it will exec itself and try to send signal again. That will
failed.
*
* After that, you will not be able to run it again since
user->sigpending
* has raised the maximum value. But there is no active task with
pending
* signals !!!
*
* You can also see in /proc/slabinfo that sigqueue pool was increase by
1024.
* Theses siqueue entries are lost and user can't send signal with
signal info
* anymore.
*
* WARNING : You have to reboot the node to restore sigqueue entries.
*
* Laurent Dufour <ldufour@meiosys.com>
*/

#define _GNU_SOURCE
#include <pthread.h>
#include <stdio.h>
#include <errno.h>
#include <string.h>
#include <signal.h>

#define SIGNAL SIGRTMAX

char *pname;

void *thread_fn(void * unused)
{
sigset_t sset;
int i;
pthread_t me = pthread_self();

sigemptyset(&sset);
sigaddset(&sset, SIGNAL);
if (pthread_sigmask(SIG_BLOCK, &sset, NULL)) {
perror("pthread_sigmask");
exit(1);
}

i=0;
while(1) {
int err = pthread_kill(me, SIGNAL);
if (err) {
if (!i) {
printf("no signal sent, pthread_kill : %s\n",
strerror(err));
exit(1);
}
break;
}
i++;
}
printf("%d signals sent. Calling exec %s\n", i, pname);

execlp(pname, pname, NULL);

perror(pname);

exit(1);
}

void sig_handler(int signal, siginfo_t *info, void * unused)
{
/* It should never be called since signal is blocked. */
printf("thread %p catch signal %s\n",
pthread_self(), strsignal(signal));
}

int main(int argc, char **argv)
{
pthread_t thread;
struct sigaction act;

setbuf(stdout,NULL);

pname = argv[0];

act.sa_sigaction = sig_handler;
sigemptyset(&act.sa_mask);
act.sa_flags = SA_RESTART | SA_NOMASK | SA_SIGINFO;
if (sigaction(SIGNAL, &act, NULL)) {
perror("sigaction");
exit(1);
}

if (pthread_create(&thread, NULL, thread_fn, NULL)) {
perror("pthread_create");
exit(1);
}

while(1) pause();
}

I hope that will help you.

Laurent.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.051 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site