Messages in this thread | | | Subject | Re: Fwd: [Bug 3592] New: pppd "IPCP: timeout sending Config-Requests" | From | Paul Fulghum <> | Date | Wed, 20 Oct 2004 18:42:40 -0500 |
| |
On Wed, 2004-10-20 at 16:57, Alan Cox wrote: > On Maw, 2004-10-19 at 16:32, Paul Fulghum wrote: > > PPP line disciplines rely on the previous behavior > > of calling ldisc->close on hangup as a method for > > indicating hangup to the line discipline. > > This is explicitly called out in the PPP ldisc comments. > > I had no choice about that really with the current locking. It's on the > list to do further work although I'd not realised some odder pppd > configurations relied upon it until the bug report.
OK
I'm not sure I would characterize using DCD for a serial connection indicator as odd.
> Once I've put out -ac1 to fix the other bugs I consider urgent (not tty) > I'll see what I can do. Really it would nice if the ppp maintainer would > look at this and also fix all the horrible things the code does wrongly > if for example the first byte of a received buffer is an error marker - > in general serial error processing is not robust in the ppp code it > appears.
I'll look at what is needed to implement the new ldisc->hangup() method for the PPP line disciplines.
-- Paul Fulghum paulkf@microgate.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |