lkml.org 
[lkml]   [2004]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 1/2] MODULE_PARM must die: make it warn first.
From
Date
Name: Warn on use of MODULE_PARM
Status: Trivial
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This patch adds a warning whenever MODULE_PARM is used. Successive
patches change them over to module_param. Help appreciated!

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .22800-linux-2.6-bk/include/linux/module.h .22800-linux-2.6-bk.updated/include/linux/module.h
--- .22800-linux-2.6-bk/include/linux/module.h 2004-10-20 15:15:30.000000000 +1000
+++ .22800-linux-2.6-bk.updated/include/linux/module.h 2004-10-20 17:11:39.000000000 +1000
@@ -562,13 +562,15 @@ struct obsolete_modparm {
char type[64-sizeof(void *)];
void *addr;
};
+
+extern void __deprecated MODULE_PARM_(void);
#ifdef MODULE
/* DEPRECATED: Do not use. */
#define MODULE_PARM(var,type) \
struct obsolete_modparm __parm_##var __attribute__((section("__obsparm"))) = \
-{ __stringify(var), type };
+{ __stringify(var), type, &MODULE_PARM_ };
#else
-#define MODULE_PARM(var,type)
+#define MODULE_PARM(var,type) static void __attribute_unused__ *__parm_##var = &MODULE_PARM_;
#endif

#define __MODULE_STRING(x) __stringify(x)
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.032 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site