Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Remove MODULE_PARM from arch/i386 | Date | Wed, 20 Oct 2004 10:25:18 -0500 |
| |
On Wednesday 20 October 2004 03:01 am, Rusty Russell wrote: > Name: Remove MODULE_PARM from i386 arch > Status: Compiled on 2.6-bk > Depends: Module/MODULE_PARM-defconfig.patch.gz > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > > This patch removes MODULE_PARM for everything under arch/i386. > Currently only APM. > > diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .3678-linux-2.6-bk/arch/i386/kernel/apm.c .3678-linux-2.6-bk.updated/arch/i386/kernel/apm.c > --- .3678-linux-2.6-bk/arch/i386/kernel/apm.c 2004-10-19 14:33:50.000000000 +1000 > +++ .3678-linux-2.6-bk.updated/arch/i386/kernel/apm.c 2004-10-20 17:56:12.000000000 +1000 > @@ -2393,27 +2393,27 @@ module_exit(apm_exit); > MODULE_AUTHOR("Stephen Rothwell"); > MODULE_DESCRIPTION("Advanced Power Management"); > MODULE_LICENSE("GPL"); > -MODULE_PARM(debug, "i"); > +module_param(debug, bool, 0644); > MODULE_PARM_DESC(debug, "Enable debug mode"); > -MODULE_PARM(power_off, "i"); > +module_param(power_off, bool, 0444); ^^^^^ I am wondering if we need to waste kernel resources by creating sysfs attributes for parameters that can not be changed at runtime (by user or kernel)...
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |