Messages in this thread | | | Date | Tue, 19 Oct 2004 15:33:08 -0700 | From | "David S. Miller" <> | Subject | Re: tun.c patch to fix "smp_processor_id() in preemptible code" |
| |
On Tue, 19 Oct 2004 18:10:58 -0400 Lee Revell <rlrevell@joe-job.com> wrote:
> /* > * Since receiving is always initiated from a tasklet (in iucv.c), > * we must use netif_rx_ni() instead of netif_rx() > */ > > This implies that the author thought it was a matter of correctness to > use netif_rx_ni vs. netif_rx. But it looks like the only difference is > that the former sacrifices preempt-safety for performance.
You can't really delete netif_rx_ni(), so if there is a preemptability issue, just add the necessary preemption protection around the softirq checks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |