lkml.org 
[lkml]   [2004]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BK PATCH] SCSI updates for 2.6.9
On Tue, Oct 19, 2004 at 08:54:43AM -0500, James Bottomley wrote:
> The condition codes are all migrating to SAM_STAT_ prefix, so
> CHECK_CONDITION becomes SAM_STAT_CHECK_CONDITION (and gets shifted in
> the process).
>
> We still have a nasty namespace pollution problem on the SCSI commands
> though and cleaning this up is problematic since they permeate not just
> SCSI but large areas of other drivers as well.

How would you feel about COMMAND_COMPLETE -> SPI_MSG_COMMAND_COMPLETE,
possibly even turning them into an enum, and putting them in the new
file <scsi/spi.h>?

That would get us out of the problems with SBP defining different numbers
for the same constants. sbp2 (a) wouldn't include <scsi/spi.h> and (b)
would use an SBP_MSG_ prefix anyway

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.199 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site