lkml.org 
[lkml]   [2004]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [1/2] PATCH Kernel watchpoint interface-2.6.9-rc4-mm1
Date
On Mon, 18 Oct 2004 14:15:25 +0530, 
Prasanna S Panchamukhi <prasanna@in.ibm.com> wrote:
>This patch provides global debug register settings.
>Used by kernel watchpoint interface patch.

>+config DEBUGREG
>+ bool "Global Debug Registers"
>+ depends on DEBUG_KERNEL
>+ help
>+ Global debug register settings will be honoured if this is turned on.
>+ If in doubt, say "N".
>+

I like most of the patch, but Kconfig is wrong. This option should not
be exposed to end users, instead CONFIG_DEBUGREG should be selected by
the debug code that calls debugreg. IOW, kgdb, kdb or kwatch select
debugreg, not the other way around.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.309 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site