Messages in this thread | | | Date | Fri, 15 Oct 2004 09:17:55 -0700 | From | Nishanth Aravamudan <> | Subject | Re: [KJ] janitoring printk with no KERN_ constants, kill all defaults? |
| |
On Fri, Oct 15, 2004 at 05:44:59PM +0200, Daniele Pizzoni wrote: > I'm investigating this (from the kernel janitors TODO list):
<snip>
> I ask, what rationale there is behind checking all printks to include > the "appropriate" constant? Should then we make printk fail when called > without KERN_ constant? Or can I force with a sed script all defaulted > printk to KERN_WARNING?
I think the rationale is to compare the comments from linux/kernel.h for the KERN_* definitions to their usage in the code and make sure they correspond accordingly, e.g. KERN_EMERG is only used if the system is actually unusable.
Hope that helps, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |